Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiida-mlip plugin #304

Merged
merged 6 commits into from
May 22, 2024
Merged

aiida-mlip plugin #304

merged 6 commits into from
May 22, 2024

Conversation

federicazanca
Copy link
Contributor

aiida-mlip plugin
machine learning interatomic potentials aiida plugin

Copy link

github-actions bot commented Feb 2, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://aiidateam.github.io/aiida-registry/pr-preview/pr-304/
on branch gh-pages at 2024-05-22 21:09 UTC

@federicazanca federicazanca marked this pull request as ready for review February 2, 2024 16:52
@federicazanca federicazanca marked this pull request as draft February 2, 2024 16:59
@ltalirz
Copy link
Member

ltalirz commented Feb 2, 2024

Hey @federicazanca , thanks for adding aiida-mlip to the registry!

I noticed in the docs preview a few suggestions, could you have a look? https://aiidateam.github.io/aiida-registry/pr-preview/pr-304/
image

@ltalirz
Copy link
Member

ltalirz commented May 21, 2024

hey @unkcpz , when you have time, would you be able to have a look at why this is failing?
it seems like there is an authentication problem (seems unrelated to this pull request)

@unkcpz
Copy link
Member

unkcpz commented May 21, 2024

Sure! I'll check it.

@unkcpz unkcpz marked this pull request as ready for review May 21, 2024 15:41
@unkcpz unkcpz self-requested a review May 21, 2024 15:41
@unkcpz
Copy link
Member

unkcpz commented May 21, 2024

Hi @federicazanca, I disable the preview action in dev-CI, the failed one is duplicate as the the preview from plugin-CI and only should be run for PR from aiidateam/aiida-registry. Can you update the PR (I guess you can see the "Update Branch" button? I cannot since the PR is from your repo, I assume.) Then all tests should pass.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @federicazanca!
Although all tests passed, the installation test is not running since you didn't specify the pip_url and the development status classifier is set to "alpha" (https://github.com/stfc/aiida-mlip/blob/18695f7793d99b5dd632bfa8d4a60057ffc64930/pyproject.toml#L18C6-L18C24)

I notice you already had the package published on pypi so I proposed the change to test installation, if everything goes fine you can see the plugin port details in the detail page.

Please also remember to update the development status in the pyproject.toml file of aiida-mlip to beta or higher once you think it is ready.

plugins.yaml Show resolved Hide resolved
Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @federicazanca

@unkcpz unkcpz merged commit a066efd into aiidateam:master May 22, 2024
9 checks passed
@federicazanca
Copy link
Contributor Author

thank you and I'll keep it updated, still working on some main features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants