Allow lambdas for InputPort default values
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the creation of the `InputPort` the optional default value will now be checked if it is a callable and if so evaluated first, before validating the returned value. In `PortNamespace.pre_process` the same check needs to be performed when the default value of a port needs to be used, evaluating it first if the default is a callable. Note that this is only done for defaults and not for port values themselves, even if callables are a valid type. If one passes a callable as a value for a port that accepts them, the user expects to get the callable back after validation and not the evaluated value.
sphuber
force-pushed
the
fix_132_lambda_defaults
branch
from
54d2566
to
91396ff
Compare
muhrin
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
During the creation of the
InputPortthe optional default value willnow be checked if it is a callable and if so evaluated first, before
validating the returned value. In
PortNamespace.pre_processthe samecheck needs to be performed when the default value of a port needs to be
used, evaluating it first if the default is a callable. Note that this
is only done for defaults and not for port values themselves, even if
callables are a valid type. If one passes a callable as a value for a
port that accepts them, the user expects to get the callable back after
validation and not the evaluated value.