Simplify parser __init__ interface. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of allowing file objects, file names, list of strings, and strings, the __init__ now always takes a single string representing the input file content.
greschd
force-pushed
the
simplify_init_interface
branch
from
d35a1c0
to
c6ee276
Compare
giovannipizzi
approved these changes
May 12, 2020
Closed
greschd
pushed a commit
to greschd/qe-tools
that referenced
this pull request
May 13, 2020
Also fixes the '--write-ref' option in the tests, which was broken in aiidateam#33 because it used the 'filename' interface of the parser __init__.
2 tasks
greschd
pushed a commit
to greschd/qe-tools
that referenced
this pull request
May 14, 2020
Also fixes the '--write-ref' option in the tests, which was broken in aiidateam#33 because it used the 'filename' interface of the parser __init__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.
Instead of allowing file objects, file names, list of strings, and strings, the
__init__now always takes a single string representing the input file content.