-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
9 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
#!/bin/sh | ||
URL="$1" | ||
REGEX="^pstorm://open/\?url=file://(.*)&line=(.*)$" | ||
REGEX="^phpstorm://open\?url=file://(.*)&line=(.*)$" | ||
|
||
if [[ $URL =~ $REGEX ]]; then | ||
/usr/local/bin/pstorm "${BASH_REMATCH[1]}:${BASH_REMATCH[2]}" | ||
fi | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d63e18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to update the run_editor.reg file? (still
pstorm
registered there)My current PhpStorm 2016.2 installation (Windows) does not have a built-in support for
phpstorm://
9d63e18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
run_editor.reg
file doesn't contain PhpStorm version. It's therun_editor.js
that has it and it's up to date as far as I can see.Sad. The project is specially designed to fill the gap and allow any PhpStorm (or other JetBrains IDE) to emulate url handling capabilities.
9d63e18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.reg and .js don't fit together here. If you change from
pstorm:
tophpstorm:
you have to update the .reg file as well.9d63e18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I thought version of PhpStorm was incorrect. Then yes, please send PR for correcting that.
9d63e18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@King2500 Thanks! See #21