This repository has been archived by the owner on Dec 9, 2019. It is now read-only.
Feature i18n improve #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/utils.js
Outdated
| @@ -11,6 +11,8 @@ import platform from 'platform' | |||
|
|
|||
| import * as constants from '../constants/Constants' | |||
|
|
|||
| const language = navigator.language.split(/[-_]/)[0]; // language without region code | |||
There was a problem hiding this comment.
@wildskyf let's have only one source of truth for language detection.
One suggestion is moving line 53 - 56 in src/index.js to src/utils/utils.js as an exported function.
wildskyf
force-pushed
the
feature__i18n_improve
branch
from
a67ed4f
to
2b22030
Compare
wildskyf
force-pushed
the
feature__i18n_improve
branch
from
2b22030
to
ca00242
Compare
sammui-AILabs
approved these changes
Feb 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.