Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-do of last categorisation & reduce number of autos #101

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Jul 1, 2024

Closes #99

  • Changed user_categorisation.R so that a user can re-do the last categorisation they made
  • Shortened down words in user prompts
  • Updated README to reflect the above changes to the code

Closes #96

  • Changed domain_mapping.R so that only one ID category is now included in the auto-categorizations. Previously there was 'ALF ID' and 'ID' and the former is SAIL specific. One ID category is simpler and more universal across datasets
  • Updated the look-up table in data and data-raw to reflect that there is now only one ID category
  • Updated README to reflect the above changes to the code, and explain a bit more about the auto categorizations

Checklist before review:

  • Please comment on my PR while it's a draft and give me feedback on the development!
  • I added everything I wanted to add to this PR, please review!
  • The title of this PR is clear and self-explantory.
  • I added any appropriate labels to this PR.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 1, 2024
@RayStick RayStick added the enhancement Feature improvement or addition label Jul 1, 2024
@RayStick RayStick changed the title allow re-do of cat + update README demo Allow re-do of last categorisation Jul 1, 2024
@RayStick RayStick marked this pull request as ready for review July 1, 2024 11:13
@RayStick RayStick changed the title Allow re-do of last categorisation Allow re-do of last categorisation & reduce number of autos Jul 2, 2024
Copy link
Contributor

@Rainiefantasy Rainiefantasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a look through the code/changes and they all look great - the plots (although from a previous commit) are a really nice addition, don't remember seeing them in my last demo run!
*edited : I couldn't get the branch to sync on R studio but as per your advice used devtools::load_all() and it's all good now!
I can see the changes, nice addition to allow re-doing of last categorisation 😸

@Rainiefantasy Rainiefantasy self-requested a review July 2, 2024 15:36
Copy link
Contributor

@Rainiefantasy Rainiefantasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and happy with all the changes - let me know if you need any more specific feedback 😸

@RayStick
Copy link
Member Author

RayStick commented Jul 2, 2024

Thanks for your review Mahwish - appreciate it!

@RayStick RayStick merged commit eb07929 into main Jul 2, 2024
2 checks passed
@RayStick RayStick deleted the go-back branch July 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Feature improvement or addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of functionality to go back and undo previous classification Interpretation of domain names in demo
2 participants