Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load feature & bug fix #97

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Load feature & bug fix #97

merged 2 commits into from
Dec 13, 2023

Conversation

Roman223
Copy link
Collaborator

@Roman223 Roman223 commented Dec 13, 2023

In order to prevent propogation of changes to input_dict, deepcopy was applied.

Now user can manually upload dict with bn to load method.

Weights changed to optional parameter.

@Roman223 Roman223 added the bug Something isn't working label Dec 13, 2023
@Roman223 Roman223 changed the title Load feature bug fix Load feature & bug fix Dec 13, 2023
Copy link
Contributor

Qodana for Python

3 new problems were found

Inspection name Severity Problems
Fixture is not requested by test functions 🔶 Warning 1
Shadowing names from outer scopes ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Roman223 Roman223 added the enhancement New feature or request label Dec 13, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (eb55164) 65.98% compared to head (63f5cb8) 65.73%.

Files Patch % Lines
bamt/networks/base.py 5.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   65.98%   65.73%   -0.25%     
==========================================
  Files          43       43              
  Lines        2902     2913      +11     
==========================================
  Hits         1915     1915              
- Misses        987      998      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roman223 Roman223 merged commit 43b0a39 into master Dec 13, 2023
6 checks passed
@Roman223 Roman223 deleted the load_feature_update branch December 13, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants