Siamese cnn #43
Merged
Siamese cnn #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing a binary classification of the signal between normal and abnormal classes
tanyapole
requested changes
Jul 26, 2023
ECG/api.py
Outdated
| @@ -201,3 +203,33 @@ def check_MI_with_NN(signal: np.ndarray) -> Tuple[bool, TextExplanation] or Fail | |||
| except Exception as e: | |||
| return Failed(reason='Failed to check for MI due to an internal error', | |||
| exception=e) | |||
|
|
|||
|
|
|||
| def perform_signal_classification(signal: np.ndarray, data_type: ECGClass)\ | |||
There was a problem hiding this comment.
все функции в апи делают классификацию сигналов. нужно говорящее имя. напр., check_ecg_is_normal
| if res == ECGStatus.NORM: | ||
| text_explanation = 'The signal is ok' | ||
| else: | ||
| text_explanation = 'The signal has some abnormalities' |
There was a problem hiding this comment.
в результате классификации сигнала ставится конкретный диагноз (в переменной res). почему вы не хотите добавить его в text_explanation?
done: - renaming api function name from "perform_signal_classification" to "check_ecg_is_normal" - changing the return type of the "check_ecg_is_normal" function to match the name more appropriately - fixing package and modules names according to PEP8 code style
tanyapole
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.