-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Siamese cnn #43
Siamese cnn #43
Conversation
Performing a binary classification of the signal between normal and abnormal classes
ECG/api.py
Outdated
@@ -201,3 +203,33 @@ def check_MI_with_NN(signal: np.ndarray) -> Tuple[bool, TextExplanation] or Fail | |||
except Exception as e: | |||
return Failed(reason='Failed to check for MI due to an internal error', | |||
exception=e) | |||
|
|||
|
|||
def perform_signal_classification(signal: np.ndarray, data_type: ECGClass)\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
все функции в апи делают классификацию сигналов. нужно говорящее имя. напр., check_ecg_is_normal
if res == ECGStatus.NORM: | ||
text_explanation = 'The signal is ok' | ||
else: | ||
text_explanation = 'The signal has some abnormalities' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в результате классификации сигнала ставится конкретный диагноз (в переменной res). почему вы не хотите добавить его в text_explanation?
done: - renaming api function name from "perform_signal_classification" to "check_ecg_is_normal" - changing the return type of the "check_ecg_is_normal" function to match the name more appropriately - fixing package and modules names according to PEP8 code style
No description provided.