Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gensim for PyPi release #1287

Merged
merged 5 commits into from
May 3, 2024
Merged

Fix gensim for PyPi release #1287

merged 5 commits into from
May 3, 2024

Conversation

DRMPN
Copy link
Collaborator

@DRMPN DRMPN commented Apr 26, 2024

This is a 🐛 bug fix

Summary

Fix gensim problem with pinned dependencies versions

Context

PyPi intermediate release 0.7.3.2 doesn't publish:

Can't have direct dependency: gensim@                                  
git+https://github.com/piskvorky/gensim.git@ad68ee3 ; extra == "extra".

https://github.com/aimclub/FEDOT/actions/runs/8849483743/job/24301597093

@DRMPN DRMPN added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 26, 2024
@DRMPN DRMPN self-assigned this Apr 26, 2024
Copy link

docu-mentor bot commented Apr 26, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Copy link
Contributor

github-actions bot commented Apr 26, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (cd915a8) to head (f3dbbd8).
Report is 5 commits behind head on master.

❗ Current head f3dbbd8 differs from pull request most recent head 26ce738. Consider uploading reports for the commit 26ce738 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   79.88%   79.90%   +0.02%     
==========================================
  Files         146      146              
  Lines       10065    10066       +1     
==========================================
+ Hits         8040     8043       +3     
+ Misses       2025     2023       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DRMPN DRMPN requested a review from nicl-nno April 26, 2024 22:59
@Lopa10ko
Copy link
Collaborator

Lopa10ko commented Apr 27, 2024

gensim редко релизится, версию специально брали с определенного коммита из-за падения интеграционников

подробнее проблема описана здесь

pypi не поддерживает такие зависимости, но должны быть workaround'ы

или нужно, наверное, менять версию scipy

Copy link
Collaborator

@Lopa10ko Lopa10ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

было бы замечательно еще несколько раз локально проверить модульные тесты и конкретный интеграционник, который падал раньше + запустить интеграционники в github actions пару раз, чтобы убедиться, что нет с ними проблем

@DRMPN
Copy link
Collaborator Author

DRMPN commented Apr 28, 2024

было бы замечательно еще несколько раз локально проверить модульные тесты и конкретный интеграционник, который падал раньше + запустить интеграционники в github actions пару раз, чтобы убедиться, что нет с ними проблем

Да, так и планировал делать.
Не нравится, что для 3.8 срабатывает таймаут на установке, так что еще попробую другие версии, мб только для этой такая проблема.
Есть идея изменить версию scipy в Големе, не знаю насколько адекватная.

@DRMPN
Copy link
Collaborator Author

DRMPN commented Apr 28, 2024

✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8866144787

@DRMPN
Copy link
Collaborator Author

DRMPN commented Apr 28, 2024

❌ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8866585903

@DRMPN
Copy link
Collaborator Author

DRMPN commented Apr 28, 2024

✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8866859667

@DRMPN
Copy link
Collaborator Author

DRMPN commented Apr 28, 2024

✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8867155981

@DRMPN
Copy link
Collaborator Author

DRMPN commented May 3, 2024

✅ Интеграционные - https://github.com/aimclub/FEDOT/actions/runs/8937098133

@DRMPN
Copy link
Collaborator Author

DRMPN commented May 3, 2024

Тесты проходят и для Голема - aimclub/GOLEM#274
Можно оставить зависимости в таком виде или же сделать новый релиз Голема с измененной версией scipy.
Тут я уже не знаю как лучше.

@DRMPN DRMPN force-pushed the DRMPN-fix-gensim-dependencies branch from 41e9c24 to 26ce738 Compare May 3, 2024 10:55
@DRMPN DRMPN merged commit 890492f into master May 3, 2024
6 checks passed
DRMPN added a commit that referenced this pull request May 3, 2024
* update version of codecov github action (#1289)

* Fix gitlab mirroring (#1288)

* Fix gensim for PyPi release (#1287)

* pin scipy version

* pin gensim version

* pin unyanked scipy version

* pin scipy versions to python versions

* simplify pin for scipy

---------

Co-authored-by: Elizaveta Lutsenko <skystar-el@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants