Fix for random state passing #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 72.88% 71.44% -1.45%
==========================================
Files 140 140
Lines 8338 8341 +3
==========================================
- Hits 6077 5959 -118
- Misses 2261 2382 +121 ☔ View full report in Codecov by Sentry. |
Nunkyl
reviewed
Apr 7, 2024
| @@ -174,6 +174,23 @@ def all_historical_quality(self, metric_position: int = 0) -> List[float]: | |||
| def show(self): | |||
| return OptHistoryVisualizer(self) | |||
|
|
|||
| # def analyze_online(self, url='https://fedot.onti.actcognitive.org'): | |||
maypink
approved these changes
Apr 9, 2024
| @@ -112,8 +112,7 @@ def __init__(self, | |||
| # TODO: rename params to avoid confusion | |||
| requirements: Optional[OptimizationParameters] = None, | |||
| graph_generation_params: Optional[GraphGenerationParams] = None, | |||
| graph_optimizer_params: Optional[AlgorithmParameters] = None, | |||
| **custom_optimizer_params): | |||
| graph_optimizer_params: Optional[AlgorithmParameters] = None): | |||
There was a problem hiding this comment.
а там не ломается использование кастомных оптимизаторов, унаследованных от него?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEDOT-related fix for reproducibility of optimiser (now only runs from GOLEM() class take the seed into account)