Python 3.7 #426
Python 3.7 #426
Conversation
|
seems like sudo needs to be enabled in travis to support python 3.7: travis-ci/travis-ci#9815 (comment) |
|
Yes, sudo+xenial just for that job |
| @@ -538,7 +538,7 @@ class MyPool(ConnectionsPool): | |||
| server.tcp_address, | |||
| minsize=10, loop=loop) | |||
|
|
|||
| with await pool as conn: | |||
| with (await pool) as conn: | |||
There was a problem hiding this comment.
It could be rewritten to async with pool.get() as conn. The deprecation warning is not triggered on ConnectionsPool objects. Rewriting as async with pool as conn generates an AttributeError because __aexit__ is not implemented like in _AsyncConnectionContextManager.
There was a problem hiding this comment.
Well, then it's a part of the fix.
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 96.69% 96.66% -0.03%
==========================================
Files 56 56
Lines 7825 7825
Branches 546 546
==========================================
- Hits 7566 7564 -2
Misses 187 187
- Partials 72 74 +2
Continue to review full report at Codecov.
|
|
Thanks |
…ed#426) * avoid deprecation warnings * adjust test * add python 3.7 to travis * add python 3.7 to appveyor * sudo:true on xenial for travis * remove 3.7 from travis * added python 3.7 to setup.py
fixes #425