Enforce passing in an instance of the aiohttp resolver, not a class (#…

…906)
aio-libs · Dec 14, 2021 · 4dff809 · 4dff809
1 parent f269b8e
commit 4dff809
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/aiobotocore/config.py b/aiobotocore/config.py
@@ -1,5 +1,4 @@
 import copy
-import inspect
 
 import botocore.client
 from botocore.exceptions import ParamValidationError
@@ -55,9 +54,9 @@ def _validate_connector_args(connector_args):
                         report='{} must be an SSLContext instance'.format(k))
             elif k == "resolver":
                 from aiohttp.abc import AbstractResolver
-                if not inspect.isclass(v) or not issubclass(v, AbstractResolver):
+                if not isinstance(v, AbstractResolver):
                     raise ParamValidationError(
-                        report='{} must be an AbstractResolver subclass'.format(k))
+                        report='{} must be an instance of a AbstractResolver'.format(k))
             else:
                 raise ParamValidationError(
                     report='invalid connector_arg:{}'.format(k))
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -45,7 +45,7 @@ def test_connector_args():
 
     # Test valid config:
     AioConfig({
-        "resolver": aiohttp.resolver.DefaultResolver
+        "resolver": aiohttp.resolver.DefaultResolver()
     })
 
     # test merge