Skip to content

Commit

Permalink
disable client getattr (#790)
Browse files Browse the repository at this point in the history
  • Loading branch information
thehesiod committed Apr 5, 2020
1 parent d7ca7ea commit 875f939
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Changes
-------
1.0.2 (2020-04-05)
^^^^^^^^^^^^^^^^^^
* Disable Client.__getattr__ emit for now #789

1.0.1 (2020-04-01)
^^^^^^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion aiobotocore/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .session import get_session, AioSession

__all__ = ['get_session', 'AioSession']
__version__ = '1.0.1'
__version__ = '1.0.2'
7 changes: 7 additions & 0 deletions aiobotocore/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ def _get_client_args(self, service_model, region_name, is_secure,


class AioBaseClient(BaseClient):
def __getattr__(self, item):
# TODO: this is not supported yet as emit_until_response is an async function
raise AttributeError(
"'%s' object has no attribute '%s'" % (
self.__class__.__name__, item)
)

async def _make_api_call(self, operation_name, api_params):
operation_model = self._service_model.operation_model(operation_name)
service_name = self._service_model.service_name
Expand Down
1 change: 1 addition & 0 deletions tests/test_patches.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
BaseClient._emit_api_params: {'2bfadaaa70671b63c50b1beed6d6c66e85813e9b'},
BaseClient.get_paginator: {'c69885f5f73fae048c0b93b43bbfcd1f9c6168b8'},
BaseClient.get_waiter: {'23d57598555bfbc4c6e7ec93406d05771f108d9e'},
BaseClient.__getattr__: {'63f8ad095789d47880867f18537a277195845111'},

# config.py
Config.merge: {'c3dd8c3ffe0da86953ceba4a35267dfb79c6a2c8'},
Expand Down

0 comments on commit 875f939

Please sign in to comment.