Skip to content

Commit

Permalink
Fixed typo when calling subprocess (#795)
Browse files Browse the repository at this point in the history
  • Loading branch information
Terry Cain committed Apr 10, 2020
1 parent 017cb59 commit acf1d1c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
Changes
-------

1.0.3 (2020-04-09)
^^^^^^^^^^^^^^^^^^
* Fixes typo when using credential process

1.0.2 (2020-04-05)
^^^^^^^^^^^^^^^^^^
* Disable Client.__getattr__ emit for now #789
Expand Down
2 changes: 1 addition & 1 deletion aiobotocore/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from .session import get_session, AioSession

__all__ = ['get_session', 'AioSession']
__version__ = '1.0.2'
__version__ = '1.0.3'
2 changes: 1 addition & 1 deletion aiobotocore/credentials.py
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ async def _retrieve_credentials_using(self, credential_process):
# We're not using shell=True, so we need to pass the
# command and all arguments as a list.
process_list = compat_shell_split(credential_process)
p = await self._popen(process_list,
p = await self._popen(*process_list,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
stdout, stderr = await p.communicate()
Expand Down
4 changes: 2 additions & 2 deletions tests/botocore/test_credentials.py
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ def _f(profile_name='default', loaded_config=None, invoked_process=None):
@pytest.mark.moto
@pytest.mark.asyncio
async def test_processprovider_retrieve_refereshable_creds(process_provider):
config = {'profiles': {'default': {'credential_process': 'my-process'}}}
config = {'profiles': {'default': {'credential_process': 'my-process /somefile'}}}
invoked_process = mock.AsyncMock()
stdout = json.dumps({
'Version': 1,
Expand All @@ -955,7 +955,7 @@ async def test_processprovider_retrieve_refereshable_creds(process_provider):
assert creds.access_key == 'foo'
assert creds.secret_key == 'bar'
assert creds.token == 'baz'
popen_mock.assert_called_with(['my-process'],
popen_mock.assert_called_with('my-process', '/somefile',
stdout=subprocess.PIPE, stderr=subprocess.PIPE)


Expand Down

0 comments on commit acf1d1c

Please sign in to comment.