Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send project-specific User-Agent HTTP header #1075

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Jan 19, 2024

Description of Change

Includes aiobotocore identifier and version in default User-Agent HTTP header.

Assumptions

Customizing the default User-Agent HTTP header is beneficial for this project and AWS, while not impacting users. See #853 for discussion.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details): closes Feature Request: AioBotocore Specific User-Agent #853

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (743c26f) 86.25% compared to head (a63e037) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
- Coverage   86.25%   86.23%   -0.03%     
==========================================
  Files          60       60              
  Lines        5858     5870      +12     
==========================================
+ Hits         5053     5062       +9     
- Misses        805      808       +3     
Flag Coverage Δ
unittests 86.23% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehesiod thehesiod merged commit c772f4b into aio-libs:master Jan 19, 2024
11 checks passed
@jakob-keller jakob-keller deleted the user-agent branch January 19, 2024 22:27
@jakob-keller jakob-keller mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: AioBotocore Specific User-Agent
2 participants