-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve read_timeout #248
resolve read_timeout #248
Conversation
thehesiod
commented
Jun 9, 2017
•
edited
edited
- fixes [Tracking] Config read_timeout not behaving correctly #245
- cleanup by moving more code to use wrapt
- implement set_socket_timeout
also some cleanup by moving more code to use wrapt
hey Jettify, let me know what you think. All this because aiohttp dev didn't want to fix a core issue in their impl :( |
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 86.28% 87.36% +1.08%
==========================================
Files 8 8
Lines 452 467 +15
==========================================
+ Hits 390 408 +18
+ Misses 62 59 -3
Continue to review full report at Codecov.
|
# Conflicts: # CHANGES.txt
I think aiohttp will do right thing eventually, we just need to make sure we can remove it easily and be very careful for each aiohttp release. By the way next aiohttp will have new multi dict that preserves original headers |
We shall see since I can't drive that anymore given his response. Should I merge this PR or would you like me change something? Thanks! |
change looks good, it uses a bit internal API but I do not see better way. We can merge, but lets do not close #245 at some point we need revert this PR once aiohttp ready |
@jettify take a look at the last commit :) Will make our lives easier |