Allow keepalive_timeout to be None #933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the library in that we could not both: * set keepalive_timeout as None * set force_close to True Validation was wrong in that it expects `keepalive_timeout` to have to be one of `float` or `int`, but it should also allow `None` since `aiohttp` requires `keepalive_timeout` to be `None` if `force_close` is set to `True`. Closes aio-libs#932
thehesiod
reviewed
May 5, 2022
| @@ -1,5 +1,9 @@ | |||
| Changes | |||
| ------- | |||
| 2.2.1 (2022-05-03) | |||
There was a problem hiding this comment.
would be nice to bump to today but I can change later
There was a problem hiding this comment.
ah, forgot to update version in __init__.py
There was a problem hiding this comment.
Shall I leave it to you to fix @thehesiod or what do you need me to do? 😄 Thanks in advance.
There was a problem hiding this comment.
I'll roll this into my current PR
thehesiod
approved these changes
May 5, 2022
|
ty! |
thehesiod
added a commit
that referenced
this pull request
May 6, 2022
|
rolled into #935, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the library in that we could not both:
keepalive_timeoutasNoneforce_closetoTrueValidation was wrong in that it expects
keepalive_timeoutto have to beone of
floatorint, but it should also allowNonesinceaiohttprequires
keepalive_timeoutto beNoneifforce_closeis set toTrue.Closes #932
Description of Change
Started to allow
Noneas value forkeepalive_timeout. Added tests accordingly.Assumptions
aiohttprequireskeepalive_timeoutto beNonewhenforce_closeisTrue, so assumed validation inaiobotocoreneeded to reflect that.Checklist for All Submissions
Closes #932