Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retries after exception normalization #989

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Conversation

thehesiod
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #989 (e037c13) into master (8d9d71a) will increase coverage by 1.75%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
+ Coverage   85.11%   86.86%   +1.75%     
==========================================
  Files          50       55       +5     
  Lines        4602     5391     +789     
==========================================
+ Hits         3917     4683     +766     
- Misses        685      708      +23     
Flag Coverage Δ
unittests 86.86% <100.00%> (+1.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiobotocore/utils.py 76.66% <ø> (-0.18%) ⬇️
tests/boto_tests/test_utils.py 95.19% <ø> (ø)
tests/python3.8/boto_tests/test_utils.py 99.28% <100.00%> (-0.01%) ⬇️
aiobotocore/_helpers.py 50.00% <0.00%> (ø)
tests/test_eventstreams.py 100.00% <0.00%> (ø)
tests/boto_tests/test_credentials.py 97.24% <0.00%> (ø)
tests/boto_tests/test_signers.py 100.00% <0.00%> (ø)
tests/test_basic_s3.py 86.22% <0.00%> (+0.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thehesiod thehesiod merged commit 14b2f5f into master Dec 22, 2022
@thehesiod thehesiod deleted the thehesiod/fix-retries branch December 22, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS_METADATA_SERVICE_NUM_ATTEMPTS effectively ignored due to uncaught botocore exceptions
1 participant