Decorators support introspection #213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 98.92% 98.92% +<.01%
==========================================
Files 12 12
Lines 651 652 +1
Branches 74 74
==========================================
+ Hits 644 645 +1
Misses 7 7
Continue to review full report at Codecov.
|
|
|
||
| assert what.__name__ == "what" | ||
| assert str(inspect.signature(what)) == '(self, a, b)' | ||
| assert inspect.getfullargspec(what.__wrapped__).args == ['self', 'a', 'b'] |
There was a problem hiding this comment.
@OOPMan have a look at the behavior here. Dunno how zope does the interface check, but it should use the signature (https://docs.python.org/3/library/inspect.html#inspect.signature) one since it enables the follow_wrapper by default.
getfullargspec (https://docs.python.org/3/library/inspect.html#inspect.getfullargspec) doesn't support following the wrapped attribute that functools.wraps adds.
There was a problem hiding this comment.
Looks good. Iirc Zope uses inspect as you have since it's the only sane way to do it. There are probably some insane ways but why worry about those :-)
There was a problem hiding this comment.
yeah, my point was more that if Zope uses inspect.signature then it will work. If it uses inspect.getfullargspec it won't because the real signature is under the __wrapped__ attribute of the function and getfullargspec doesn't use it (while signature does :))
Closes #212