Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List should show timestamp for recent files instead of current year #36

Merged
merged 1 commit into from
Feb 19, 2016
Merged

List should show timestamp for recent files instead of current year #36

merged 1 commit into from
Feb 19, 2016

Conversation

rsichnyi
Copy link
Contributor

No description provided.

@pohmelie
Copy link
Collaborator

First of all, when I implement list, I read, that there is no standard for list format. So there is nothing good and nothing bad with this pull. So, it will be accepted, since human readability. 👌

  • What is the reason to change datetime.datetime.fromtimestamp to time.time?
  • Why half of year branching?
  • More obvious way to find delta is timedelta.days, I think.

@rsichnyi
Copy link
Contributor Author

it's a copy-paste from asyncssh (https://github.com/ronf/asyncssh/blob/master/asyncssh/sftp.py#L3372), i didn't bother to improve the code - it's simple enough

regarding 6 month it's how nx ls -l works, see http://git.savannah.gnu.org/cgit/coreutils.git/tree/src/ls.c#n4015

pohmelie added a commit that referenced this pull request Feb 19, 2016
server: list should show timestamp for recent files instead of current year
@pohmelie pohmelie merged commit 91476f6 into aio-libs:master Feb 19, 2016
@pohmelie pohmelie mentioned this pull request Feb 19, 2016
2 tasks
@rsichnyi rsichnyi deleted the fix-list-timestamp branch February 19, 2016 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants