Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect name on aiohttp_cors.urldispatcher_router_adapter._is_web_view #215

Closed
diogommartins opened this issue Jan 9, 2019 · 2 comments · Fixed by #216
Closed

Incorrect name on aiohttp_cors.urldispatcher_router_adapter._is_web_view #215

diogommartins opened this issue Jan 9, 2019 · 2 comments · Fixed by #216
Labels
pr-merged

Comments

@diogommartins
Copy link
Contributor

diogommartins commented Jan 9, 2019 •
edited
Loading 

raise ValueError("web view should be derived from "
                                     "aiohttp_cors.WebViewMixig for working "
                                     "with the library")

I think that aiohttp_cors.WebViewMixig should change to aiohttp_cors.CorsViewMixin. If its ok, ill submit a PR
diogommartins added a commit to diogommartins/aiohttp-cors that referenced this issue Jan 9, 2019
@diogommartins
aio-libs#215 - fixing exception message
79e68f7
@asvetlov
Copy link
Member

asvetlov commented Jan 9, 2019

Good catch!
Please do.

@diogommartins
Copy link
Contributor Author

Done here #216 @asvetlov

@diogommartins diogommartins mentioned this issue Jan 9, 2019
Merged
asvetlov pushed a commit that referenced this issue Jun 14, 2019
@diogommartins @asvetlov
#215 - fixing exception message (#216)
89e6632
@helpr helpr bot added the pr-merged label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#215 - fixing exception message diogommartins/aiohttp-cors
2 participants
@asvetlov @diogommartins