Fix unquoting #165
Fix unquoting #165
Conversation
aiohttp_devtools/runserver/serve.py
Outdated
| @@ -295,7 +295,7 @@ def modify_request(self, request): | |||
| """ | |||
| Apply common path conventions eg. / > /index.html, /foobar > /foobar.html | |||
| """ | |||
| filename = unquote(request.match_info['filename']) | |||
| filename = URL(request.match_info['filename'], encoded=True).path | |||
There was a problem hiding this comment.
URL.build(path=...) is even better.
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
======================================
Coverage 94.9% 94.9%
======================================
Files 12 12
Lines 765 765
Branches 93 93
======================================
Hits 726 726
Misses 25 25
Partials 14 14
Continue to review full report at Codecov.
|
|
updated travis.yml as well to test against current aiohttp version |
|
Please, merge it :) |
- use yarl public api to unquote - update travis env to use latest aiohttp compatible version(2.3.9)
|
please fix and I'll merge |
|
not sure what to do with the failing aiohttp 2.0 test(using yarl 0.10.3) |
|
as per #164 I think we're happy to drop |
- use yarl public api to unquote - update travis env to use latest aiohttp compatible version(2.3.9)
|
I'm replacing this with #170 as the changed required conflicted and I want to release an update. |
* when not serving static files, don't mess the apps static_root_url tests updated changed middleware to aiohttp's newer decorator middleware * change aiohttp versions supported * Fix unquoting, picked from #165 - use yarl public api to unquote - update travis env to use latest aiohttp compatible version(2.3.9) * require aiohttp>=2.3.9
use yarl public api to unquote