Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional static_root_url and unquote #170

Merged
merged 4 commits into from
Jan 18, 2018
Merged

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Jan 18, 2018

replace #164 and #165
fixes #167

tests updated
changed middleware to aiohttp's newer decorator middleware
samuelcolvin and others added 2 commits January 18, 2018 19:42
- use yarl public api to unquote
- update travis env to use latest aiohttp compatible version(2.3.9)
@samuelcolvin samuelcolvin changed the title Optional static_root_url Optional static_root_url and unquote Jan 18, 2018
@samuelcolvin samuelcolvin mentioned this pull request Jan 18, 2018
@codecov
Copy link

codecov bot commented Jan 18, 2018

Codecov Report

Merging #170 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage    94.9%   94.89%   -0.01%     
==========================================
  Files          12       12              
  Lines         765      764       -1     
  Branches       93       94       +1     
==========================================
- Hits          726      725       -1     
  Misses         25       25              
  Partials       14       14
Impacted Files Coverage Δ
aiohttp_devtools/version.py 100% <100%> (ø) ⬆️
aiohttp_devtools/runserver/serve.py 94.27% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ef2dc...71951f6. Read the comment docs.

@samuelcolvin samuelcolvin merged commit fd1ea6a into master Jan 18, 2018
@samuelcolvin samuelcolvin deleted the optional-static-root-url branch January 18, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'unquote'
2 participants