🐽 Fix memory leak in chunked streams handling code (#3631)

aio-libs · Mar 3, 2019 · e9ac7d1 · e9ac7d1
1 parent 398b5ba
commit e9ac7d1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES/3631.bugfix b/CHANGES/3631.bugfix
@@ -0,0 +1 @@
+Cleanup per-chunk data in generic data read. Memory leak fixed.
diff --git a/aiohttp/streams.py b/aiohttp/streams.py
@@ -460,6 +460,11 @@ def _read_nowait_chunk(self, n: int) -> bytes:
         self._size -= len(data)
         self._cursor += len(data)
 
+        chunk_splits = self._http_chunk_splits
+        # Prevent memory leak: drop useless chunk splits
+        while chunk_splits and chunk_splits[0] < self._cursor:
+            chunk_splits.pop()
+
         if self._size < self._low_water and self._protocol._reading_paused:
             self._protocol.resume_reading()
         return data