New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() #1593

Closed
AraHaan opened this Issue Feb 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@AraHaan
Contributor

AraHaan commented Feb 7, 2017

aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() are deprecated, use the ones in aiohttp.ClientSession() instead.

People using these deprecated versions had plenty of time to move to the ones in ClientSession instead.

Remove in v1.4.

@AraHaan AraHaan changed the title from Drop deprecated functions in client.py to Drop aiohttp.request(), aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() Feb 7, 2017

@fafhrd91

This comment has been minimized.

Member

fafhrd91 commented Feb 7, 2017

i am not sure about this.

@fafhrd91 fafhrd91 added the deprecate label Feb 7, 2017

@fafhrd91 fafhrd91 changed the title from Drop aiohttp.request(), aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() to Drop aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() Feb 8, 2017

@fafhrd91 fafhrd91 added this to the 1.4 milestone Feb 8, 2017

fafhrd91 pushed a commit that referenced this issue Feb 8, 2017

Nikolay Kim

fafhrd91 pushed a commit that referenced this issue Feb 8, 2017

Nikolay Kim

fafhrd91 pushed a commit that referenced this issue Feb 8, 2017

Nikolay Kim
dropped aiohttp.get(), aiohttp.options(), aiohttp.head(),
 aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(),
 and aiohttp.ws_connect() #1593

@fafhrd91 fafhrd91 closed this Feb 8, 2017

@AraHaan

This comment has been minimized.

Contributor

AraHaan commented Feb 16, 2017

thanks, Also I just realized I forgot to include to drop aiohttp.request since aiohttp.ClientSession().request basically replaces it as well. @fafhrd91 sorry about that.

@fafhrd91

This comment has been minimized.

Member

fafhrd91 commented Feb 16, 2017

i removed request() from list, i do not want to remove it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment