Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() #1593

Closed
AraHaan opened this issue Feb 7, 2017 · 4 comments
Closed

Drop aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() #1593

AraHaan opened this issue Feb 7, 2017 · 4 comments
Labels
outdated
Milestone
2.0

Comments

@AraHaan
Copy link
Contributor

AraHaan commented Feb 7, 2017 •
edited by fafhrd91

aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() are deprecated, use the ones in aiohttp.ClientSession() instead.

People using these deprecated versions had plenty of time to move to the ones in ClientSession instead.

Remove in v1.4.
@AraHaan AraHaan changed the title Drop deprecated functions in client.py Drop aiohttp.request(), aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() Feb 7, 2017
@fafhrd91
Copy link
Member

fafhrd91 commented Feb 7, 2017

i am not sure about this.

@fafhrd91 fafhrd91 changed the title Drop aiohttp.request(), aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() Drop aiohttp.get(), aiohttp.options(), aiohttp.head(), aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(), and aiohttp.ws_connect() Feb 8, 2017
@fafhrd91 fafhrd91 added this to the 1.4 milestone Feb 8, 2017
fafhrd91 pushed a commit that referenced this issue Feb 8, 2017
add #1593 to 1.3 release
d32145e
fafhrd91 pushed a commit that referenced this issue Feb 8, 2017
add #1593 to 1.3 release
ecf267e
fafhrd91 pushed a commit that referenced this issue Feb 8, 2017
dropped aiohttp.get(), aiohttp.options(), aiohttp.head(),
568f690 
 aiohttp.post(), aiohttp.put(), aiohttp.patch(), aiohttp.delete(),
 and aiohttp.ws_connect() #1593
@fafhrd91 fafhrd91 closed this as completed Feb 8, 2017
@AraHaan
Copy link
Contributor Author

AraHaan commented Feb 16, 2017

thanks, Also I just realized I forgot to include to drop aiohttp.request since aiohttp.ClientSession().request basically replaces it as well. @fafhrd91 sorry about that.

@fafhrd91
Copy link
Member

i removed request() from list, i do not want to remove it for now

@aio-libs-bot aio-libs-bot mentioned this issue Dec 4, 2018
Closed
@switowski switowski mentioned this issue Apr 12, 2019
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@fafhrd91 @AraHaan