Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where is the proxies parameter of ClientSession? And how could I add proxy for whole session? #2580

Open
fy0 opened this issue Dec 1, 2017 · 3 comments
Open

Where is the proxies parameter of ClientSession? And how could I add proxy for whole session? #2580

fy0 opened this issue Dec 1, 2017 · 3 comments

Comments

@fy0
Copy link

fy0 commented Dec 1, 2017

Long story short

Document:

http://aiohttp.readthedocs.io/en/stable/client_reference.html#aiohttp.ClientSession

class aiohttp.ClientSession(*, connector=None, loop=None, ..., proxies=None)

Real world:

https://github.com/aio-libs/aiohttp/blob/master/aiohttp/client.py#L53-L62

Well, what happened?

Expected behaviour

Actual behaviour

Steps to reproduce

Your environment

aiohttp 2.3.5
@fy0 fy0 changed the title Where is the proxies parameter of ClientSession? And how could I add proxy for session? Where is the proxies parameter of ClientSession? And how could I add proxy for whole session? Dec 1, 2017
@fy0
Copy link
Author

fy0 commented Dec 1, 2017

working on fix

@asvetlov
Copy link
Member

asvetlov commented Dec 1, 2017

Please do

fy0 added a commit to fy0/aiohttp that referenced this issue Dec 1, 2017
@fy0
Added proxy parameters for ClientSession (aio-libs#2580)
8cb2928
@fy0 fy0 mentioned this issue Dec 1, 2017
Closed
5 tasks
@RatanShreshtha
Copy link

Please merge the PR for creating sessions with the proxy.

@RatanShreshtha RatanShreshtha mentioned this issue Nov 22, 2018
Closed
5 tasks
@CoolSpring8 CoolSpring8 mentioned this issue Apr 22, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @fy0 @RatanShreshtha