-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @unittest_run_loop #5516
Conversation
@Dreamsorcerer is the new default on regardless of the Python version? |
Appears to have a fallback on asynctest, so looks like it: |
Could you make sure that there's a test for this then? |
Codecov Report
@@ Coverage Diff @@
## master #5516 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 41 41
Lines 8860 8854 -6
Branches 1424 1424
==========================================
- Hits 8610 8604 -6
Misses 133 133
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Indeed, the test_test_utils.py covers this already: |
Removes the now unneeded @unittest_run_loop from master.