Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @unittest_run_loop #5516

Merged
merged 8 commits into from Mar 4, 2021
Merged

Remove @unittest_run_loop #5516

merged 8 commits into from Mar 4, 2021

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Mar 4, 2021

Removes the now unneeded @unittest_run_loop from master.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 4, 2021
@Dreamsorcerer Dreamsorcerer changed the title Update unittest docs Remove @unittest_run_loop Mar 4, 2021
@Dreamsorcerer Dreamsorcerer marked this pull request as ready for review March 4, 2021 14:14
@webknjaz
Copy link
Member

webknjaz commented Mar 4, 2021

@Dreamsorcerer is the new default on regardless of the Python version?

@Dreamsorcerer
Copy link
Member Author

@Dreamsorcerer is the new default on regardless of the Python version?

Appears to have a fallback on asynctest, so looks like it:
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/test_utils.py#L60

@webknjaz
Copy link
Member

webknjaz commented Mar 4, 2021

Appears to have a fallback on asynctest, so looks like it:
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/test_utils.py#L60

Could you make sure that there's a test for this then?

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #5516 (39100f5) into master (a970c50) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
- Coverage   97.17%   97.17%   -0.01%     
==========================================
  Files          41       41              
  Lines        8860     8854       -6     
  Branches     1424     1424              
==========================================
- Hits         8610     8604       -6     
  Misses        133      133              
  Partials      117      117              
Flag Coverage Δ
unit 97.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/test_utils.py 99.68% <ø> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a970c50...dd1ad97. Read the comment docs.

@Dreamsorcerer
Copy link
Member Author

Could you make sure that there's a test for this then?

Indeed, the test_test_utils.py covers this already:
https://github.com/aio-libs/aiohttp/blob/unittest1/tests/test_test_utils.py#L105-L109

@webknjaz webknjaz merged commit 25dfe50 into master Mar 4, 2021
@webknjaz webknjaz deleted the unittest2 branch March 4, 2021 23:39
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants