fix header encoding error

[benoitc]

find embedded a patch fixing benoitc/gunicorn#775

--- protocol.orig.py    2014-06-07 15:19:01.234911490 +0200
+++ protocol.py 2014-06-07 15:22:23.158921591 +0200
@@ -629,8 +629,9 @@
         # status + headers
         hdrs = ''.join(itertools.chain(
            (self.status_line,),
-           *((k, ': ', v, '\r\n') for k, v in self.headers)))
-        hdrs = hdrs.encode('ascii') + b'\r\n'
+            *((k, ': ', str(v).strip(), '\r\n') for k, v in self.headers)))
+
+        hdrs = hdrs.encode('utf8') + b'\r\n'

         self.output_length += len(hdrs)
         self.transport.write(hdrs)

[asvetlov]

LGTM
@fafhrd91 thoughts?

[fafhrd91]

I think we should add check for Unicode in add_header method.

[asvetlov]

@fafhrd91 something like

assert isinstance(value, str), '{!r} is not a string'.format(value)

???

[fafhrd91]

Yes, I think assert is enough. add_header already expects value as a string object in any case

[asvetlov]

Done in #68

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.