Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf8 headers #68

Merged
merged 3 commits into from
Jun 7, 2014
Merged

Utf8 headers #68

merged 3 commits into from
Jun 7, 2014

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 7, 2014

See also #67

@fafhrd91 I'll push it in master if you have no objections

@fafhrd91
Copy link
Member

fafhrd91 commented Jun 7, 2014

Lgtm, could you just move value.strip() under name.strip()

asvetlov added a commit that referenced this pull request Jun 7, 2014
Add support for utf-8 values in HTTP headers
@asvetlov asvetlov merged commit 64f5fe2 into master Jun 7, 2014
@asvetlov asvetlov deleted the utf8_headers branch June 7, 2014 14:53
@asvetlov
Copy link
Member Author

asvetlov commented Jun 7, 2014

Done.
Perhaps we need for new release to satisfy @benoitc gunicorn dependency.

@asvetlov asvetlov mentioned this pull request Jun 7, 2014
@fafhrd91
Copy link
Member

fafhrd91 commented Jun 7, 2014

I think we should integrate multidict first. My recent exceptions change brakes backward compatibility. I prefer to brake everything at the same time :)

@asvetlov
Copy link
Member Author

asvetlov commented Jun 7, 2014

@fafhrd91 sounds good for me.

@benoitc
Copy link

benoitc commented Jun 7, 2014

when do you plane to make it? Anyway we can probably release gunicorn and
tell to people the current worker is experimental and works only on yourl
atets master. What do you think?

On Sat, Jun 7, 2014 at 5:02 PM, Andrew Svetlov notifications@github.com
wrote:

@fafhrd91 https://github.com/fafhrd91 sounds good for me.


Reply to this email directly or view it on GitHub
#68 (comment).

@fafhrd91
Copy link
Member

fafhrd91 commented Jun 7, 2014

in most cases current aiohttp release should work :)
i’m planing to release next version on monday.

On Jun 7, 2014, at 8:39 AM, Benoit Chesneau notifications@github.com wrote:

when do you plane to make it? Anyway we can probably release gunicorn and
tell to people the current worker is experimental and works only on yourl
atets master. What do you think?

On Sat, Jun 7, 2014 at 5:02 PM, Andrew Svetlov notifications@github.com
wrote:

@fafhrd91 https://github.com/fafhrd91 sounds good for me.


Reply to this email directly or view it on GitHub
#68 (comment).


Reply to this email directly or view it on GitHub.

@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants