-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot install from source #7802
Comments
This is by design, currently. Building from source requires cloning a Git repository and including the llhttp submodule. GitHub's Git archive exports don't include submodules recursively so you download an incomplete snapshot of the repo. The only official source to build from like that is the sdist on PyPI. Use that. |
Just in case anyone in the future wants to address it, my comment here has a simple solution: |
I added a comment there explaining that the idea has bad consequences. We wouldn't accept such a hack. |
Thank you for this, it was helpful to bisect to find a recent regression with EDIT: |
Describe the bug
Attempting to install from source (
pip install 'https://github.com/aio-libs/aiohttp/releases/download/v3.9.0b1/aiohttp-3.9.0b1.tar.gz'
), or from the git repository fails (see below).It appears that
setup.py
is missing the necessary execution steps to convert thepyx
files toc
files for building.To Reproduce
python -m venv venv
. ./venv/bin/activate
pip install 'git+https://github.com/aio-libs/aiohttp#egg=aiohttp'
Expected behavior
I expect that
aiohttp
will be installed and usable.Logs/tracebacks
Python Version
aiohttp Version
multidict Version
yarl Version
OS
MacOS 14.1 (23B74)
Related component
Server, Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: