Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation about testing with the explicit loop #1097

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Added documentation about testing with the explicit loop #1097

merged 1 commit into from
Aug 19, 2016

Conversation

argaen
Copy link
Member

@argaen argaen commented Aug 19, 2016

What do these changes do?

Updates on documentation about how to test by passing the loop explicitly and why you should do that.

Related issue number

#1069

@codecov-io
Copy link

codecov-io commented Aug 19, 2016

Current coverage is 97.71% (diff: 100%)

Merging #1097 into master will not change coverage

@@             master      #1097   diff @@
==========================================
  Files            28         28          
  Lines          6434       6434          
  Methods           0          0          
  Messages          0          0          
  Branches       1094       1094          
==========================================
  Hits           6287       6287          
  Misses           77         77          
  Partials         70         70          

Powered by Codecov. Last update 4599080...abc767e

@asvetlov asvetlov merged commit f3881d1 into aio-libs:master Aug 19, 2016
@asvetlov
Copy link
Member

Thanks!
Feel free for adding very explained texts about aiohttp problems and best usage practices like this one.

@argaen argaen deleted the issue-1069/document-explicit-loop-for-tests branch August 19, 2016 19:07
@argaen
Copy link
Member Author

argaen commented Aug 19, 2016

Sure! :)

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants