Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1069/document explicit loop for tests #1109

Merged

Conversation

argaen
Copy link
Member

@argaen argaen commented Aug 23, 2016

Added the lambda example in the first TestAcceptance for consistency with the last full tests file example

Before only loop was being passed to the constructor example.
If the service required args, the example would fail. With the new example,
any args and kwargs received from the calling service will be passed
correctly to the tested service
@argaen
Copy link
Member Author

argaen commented Aug 23, 2016

ermmm dunno why it's trying to add a commit already merged again 😓

@codecov-io
Copy link

Current coverage is 97.70% (diff: 100%)

Merging #1109 into master will increase coverage by 0.34%

@@             master      #1109   diff @@
==========================================
  Files            28         28          
  Lines          6409       6409          
  Methods           0          0          
  Messages          0          0          
  Branches       1078       1078          
==========================================
+ Hits           6240       6262    +22   
+ Misses           87         80     -7   
+ Partials         82         67    -15   

Powered by Codecov. Last update 2d574b7...5968d86

@asvetlov asvetlov merged commit 96f5415 into aio-libs:master Aug 23, 2016
@asvetlov
Copy link
Member

#1069

@argaen argaen deleted the issue-1069/document-explicit-loop-for-tests branch August 23, 2016 21:52
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants