Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with IndexError being raised by the StreamReader.iter_chunks() generator #2113

Merged
merged 4 commits into from Jul 21, 2017

Conversation

jlacoline
Copy link
Contributor

@jlacoline jlacoline commented Jul 19, 2017

What do these changes do?

Make StreamReader.readchunk method return b"" when buffer is empty eof is reached

Are there changes in behavior for the user?

Fixes the IndexError raised when using iter_chunks()

Related issue number

#2112

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #2113 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
+ Coverage   97.08%   97.11%   +0.02%     
==========================================
  Files          38       38              
  Lines        7692     7694       +2     
  Branches     1345     1346       +1     
==========================================
+ Hits         7468     7472       +4     
+ Misses        102      101       -1     
+ Partials      122      121       -1
Impacted Files Coverage Δ
aiohttp/streams.py 98.75% <100%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4064cbd...f9281cb. Read the comment docs.

@fafhrd91
Copy link
Member

Thanks!

@fafhrd91 fafhrd91 merged commit 240a0e2 into aio-libs:master Jul 21, 2017
@jlacoline jlacoline deleted the fix_streams_readchunk branch July 21, 2017 08:02
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants