Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_client_ws.py and test_client_ws_functional.py now use async/await syntax #2364

Merged
merged 28 commits into from Oct 21, 2017
Merged

Conversation

eteamin
Copy link
Contributor

@eteamin eteamin commented Oct 20, 2017

issue #2343

@eteamin eteamin changed the title test_client_ws.py and test_client_ws_functional now use async/await syntax test_client_ws.py and test_client_ws_functional.py now use async/await syntax Oct 20, 2017
@codecov-io
Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #2364 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2364   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          39       39           
  Lines        8180     8180           
  Branches     1419     1419           
=======================================
  Hits         7949     7949           
  Misses        101      101           
  Partials      130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daed180...72a8c24. Read the comment docs.

@eteamin
Copy link
Contributor Author

eteamin commented Oct 21, 2017

There is something about this. If I change the inner coro to async coro(), test_tcp_connector_use_dns_cache_disabled() will fail due to Runtime Error for awaiting a coroutine twice here. I found some info here but I couldn't find a workaround to solve it.

@asvetlov asvetlov merged commit 21f443b into aio-libs:master Oct 21, 2017
@asvetlov
Copy link
Member

Tests are passed correctly.
Thanks.

@asvetlov
Copy link
Member

@eteamin JFYI I've fixed by test_tcp_connector_use_dns_cache_disabled() 146a660

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants