Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_multipart.py now uses async/await syntax #2373

Merged
merged 34 commits into from Oct 23, 2017
Merged

test_multipart.py now uses async/await syntax #2373

merged 34 commits into from Oct 23, 2017

Conversation

eteamin
Copy link
Contributor

@eteamin eteamin commented Oct 22, 2017

issue #2343

eteamin and others added 30 commits October 19, 2017 00:39
@eteamin
test_classbasedview now uses async/await syntax
21e12e0
@eteamin
test_client_functional.py now uses async/await syntax
4a0c210
@eteamin
test_client_functional_oldstyle.py now uses async/await syntax
fdebb4d
@eteamin
reverting test_client_functional_oldstyle to old file
6e75358
@eteamin
test_client_proto.py now uses async/await style
a56575f
@eteamin
fixed PEP errors mentioned by flake8
2efb0c2
@eteamin
Merge branch 'master' into master
07b0683
@eteamin
fixed flake8 warning for blank lines that contain whitespace
1572a53
@eteamin
Merge branch 'master' of github.com:eteamin/aiohttp
3b8f09f 
o
@eteamin
fixed import order
0211e93
@asvetlov
Merge branch 'master' into master
d1eb6df
@asvetlov
Merge branch 'master' into master
64d0be7
@eteamin
test_client_session.py now uses async/await syntax
81edcac
@eteamin
Merge branch 'master' into master
2cecaf5
@eteamin
test_client_request.py and test_client_response.py now use async/awai…
dbcdb65 
…t syntax
@eteamin
Merge branch 'master' of github.com:eteamin/aiohttp
efe8aff 
o
@eteamin
Update CONTRIBUTORS.txt
b097735
@eteamin
coro to be represtend as coroutine than generator
6de7e2d
@eteamin
Merge branch 'master' of github.com:eteamin/aiohttp
ae358bf 
o
@asvetlov
Merge branch 'master' into master
bd2b8c5
@asvetlov
Merge branch 'master' into master
94d7f96
@eteamin
test_client_ws.py now uses async/await syntax
00d7ffc
@eteamin
test_client_ws_functional.py now uses async/await syntax
72a8c24
@eteamin
test_connector.py now uses async/await syntax
e254e3c
@asvetlov
Merge branch 'master' into master
35ad229
@asvetlov
Merge branch 'master' into master
efa5df3
@asvetlov
Merge branch 'master' into master
5596a25
@asvetlov
Merge branch 'master' into master
6a54c27
@eteamin
test_formdata.py and test_http_writer.py now use async/await syntax
5fef728
@asvetlov
Merge branch 'master' into master
17341b1
kxepal
kxepal requested changes Oct 22, 2017
View reviewed changes
Copy link
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, but you should rebase your branch against master. There are too many commits in this PR.

@eteamin
Copy link
Contributor Author

eteamin commented Oct 22, 2017

I did!

@asvetlov
Copy link
Member

There are many other yield from expressions left in test_multipart.py.
The file is slightly not accurate, not all coroutines are marked by @asyncio.coroutine decorator -- but all functions containing yield from should be converted into async def with replacement yield from to await.

@asvetlov
Copy link
Member

Yep, too many commits but I could live with it for now.
For next PR sync your clone with upstream.
Or just make a new clone.

@asvetlov asvetlov merged commit bce1805 into aio-libs:master Oct 23, 2017
@eteamin eteamin mentioned this pull request Oct 25, 2017
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kxepal kxepal kxepal requested changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eteamin @asvetlov @kxepal