Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in FileResponse when compression wouldn't work #2944

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

roganov
Copy link
Contributor

@roganov roganov commented Apr 17, 2018

Closes #2942

What do these changes do?

Compression of FileResponse's now works

Are there changes in behavior for the user?

Compression works

Related issue number

#2942

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@@ -43,7 +43,7 @@ def __init__(self, *, status=200, reason=None, headers=None):
self._keep_alive = None
self._chunked = False
self._compression = False
self._compression_force = False
self._compression_force = None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this so that type is simplified to Optional[ContentCoding], not Union[None, bool, ContentCoding]

@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #2944 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2944   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          40       40           
  Lines        7514     7514           
  Branches     1318     1318           
=======================================
  Hits         7363     7363           
  Misses         48       48           
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 98.01% <100%> (ø) ⬆️
aiohttp/web_response.py 98.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544716c...d52b94c. Read the comment docs.

@asvetlov asvetlov merged commit 26802e0 into aio-libs:master Apr 17, 2018
@asvetlov
Copy link
Member

Thank you!

thehesiod pushed a commit to thehesiod-forks/aiohttp that referenced this pull request Apr 26, 2018
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_compression doesn't work with FileResponse in sendfile mode
3 participants