Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse a connection with the same URL but different proxy/TLS settings #2985

Merged
merged 3 commits into from May 10, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented May 8, 2018

Fixes #2981

@codecov-io
Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #2985 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
+ Coverage   98.08%   98.08%   +<.01%     
==========================================
  Files          41       41              
  Lines        7621     7632      +11     
  Branches     1324     1327       +3     
==========================================
+ Hits         7475     7486      +11     
  Misses         49       49              
  Partials       97       97
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.42% <100%> (+0.04%) ⬆️
aiohttp/connector.py 98.17% <100%> (ø) ⬆️
aiohttp/client_exceptions.py 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0378bd...9021281. Read the comment docs.

@asvetlov
Copy link
Member Author

asvetlov commented May 8, 2018

Ready for review

@asvetlov asvetlov merged commit 965ddc1 into master May 10, 2018
@asvetlov asvetlov deleted the request-key branch May 10, 2018 08:11
asvetlov added a commit that referenced this pull request May 10, 2018
…ttings (#2985)

* Fix #2981: Don't reuse a connection with the same URL but different proxy/TLS settings

* Add TLS to white list

* Fix broken TLS over proxy
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy behavior is inconsistent
2 participants