Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3852 - aiohttp.test_utils.TestClient should return a _RequestContextManager #3989

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Fixes #3852 - aiohttp.test_utils.TestClient should return a _RequestContextManager #3989

merged 2 commits into from
Aug 30, 2019

Conversation

Transfusion
Copy link
Contributor

@Transfusion Transfusion commented Aug 17, 2019 •
edited by asvetlov
Loading

What do these changes do?

Are there changes in behavior for the user?

Related issue number

#3852

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 17, 2019
@codecov-io
Copy link

codecov-io commented Aug 17, 2019 •
edited
Loading

Codecov Report

Merging #3989 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3989      +/-   ##
==========================================
+ Coverage   97.78%   97.78%   +<.01%     
==========================================
  Files          43       43              
  Lines        8763     8765       +2     
  Branches     1375     1375              
==========================================
+ Hits         8569     8571       +2     
  Misses         81       81              
  Partials      113      113
Impacted Files Coverage Δ
aiohttp/test_utils.py 99.67% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e804981...feee24e. Read the comment docs.

@asvetlov asvetlov merged commit a2a9d0a into aio-libs:master Aug 30, 2019
@asvetlov
Copy link
Member

Thanks!

asvetlov pushed a commit that referenced this pull request Aug 30, 2019
@Transfusion @asvetlov
[3.6] Fixes #3852 - aiohttp.test_utils.TestClient should return a _Re…
6ed27b8 
…questContextManager (#3989)

(cherry picked from commit a2a9d0a)

Co-authored-by: Bryan Kok <Transfusion@users.noreply.github.com>
asvetlov added a commit that referenced this pull request Aug 30, 2019
@asvetlov @Transfusion
[3.6] Fixes #3852 - aiohttp.test_utils.TestClient should return a _Re…
0929934 
…questContextManager (#3989) (#4022)

(cherry picked from commit a2a9d0a)

Co-authored-by: Bryan Kok <Transfusion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Transfusion @codecov-io @asvetlov