Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal logging config to the documentation #4087

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

AlexDobrushskiy
Copy link
Contributor

@AlexDobrushskiy AlexDobrushskiy commented Sep 24, 2019

What do these changes do?

Adds minimal required logging configuration to the logging documentation section.

Are there changes in behavior for the user?

No.

Related issue number

2469

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #4087 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4087      +/-   ##
==========================================
- Coverage   97.77%   97.72%   -0.05%     
==========================================
  Files          43       43              
  Lines        8763     8763              
  Branches     1374     1374              
==========================================
- Hits         8568     8564       -4     
- Misses         82       85       +3     
- Partials      113      114       +1
Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 96.59% <0%> (-1.14%) ⬇️
aiohttp/connector.py 96.93% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb18a2...cfe5ddd. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asvetlov asvetlov merged commit 31ef9e1 into aio-libs:master Sep 24, 2019
asvetlov pushed a commit that referenced this pull request Sep 24, 2019
* Add minimal logging config to the documentation

* Add blank line according to the linter rules

* Add CHANGES record
(cherry picked from commit 31ef9e1)

Co-authored-by: Alexey Dobrushskiy <a.dobrushskiy@gmail.com>
asvetlov added a commit that referenced this pull request Sep 24, 2019
* Add minimal logging config to the documentation

* Add blank line according to the linter rules

* Add CHANGES record
(cherry picked from commit 31ef9e1)

Co-authored-by: Alexey Dobrushskiy <a.dobrushskiy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants