fix response.text property

[jettify]

response.text has unexpected behavior:

response = Rresponse(status=200)
print(response.text)

results in:

File "/home/nick/sources/python/aiohttp/aiohttp/web_reqrep.py", line 743, in text
    return self._body.decode(self.charset or 'utf-8')
nose.proxy.AttributeError: 'NoneType' object has no attribute 'decode '

here tiny fix.

[fafhrd91]

-1 i do not like to use two different types for same attribute, text should be str only. same for body, it should be bytes only.
i'd prefer to use empty str and bytes as default values

[jettify]

Ok, I've made changes, now body is bytes only and text is str only. For empty payload:b'' and ''

[fafhrd91]

lgtm from me
@asvetlov ?

[asvetlov]

We have documented None for body andtext`: http://aiohttp.readthedocs.org/en/stable/web_reference.html#aiohttp.web.Response.text

I'm -0.5 for making it str only, we slightly break backward compatibility.

@fafhrd91 if you insist on converting it to str documentation should be updated.
But I believe None is sigh of body absence while '' is for empty but present http payload.
It may behave differently for gzipped or chunked payload.

[fafhrd91]

i am +-0 on this. i just do not like to use two different types for one attribute.

[asvetlov]

I think having None as not specified is good for every basic type: str, int, float etc.

It works like implicit enum Optional<str> for Swift for example -- nil is valid value as well as empty string but these are not equal.

[fafhrd91]

in swift it is different, you have to explicitly unwrap optional value, and again optional attribute has one type which is enum Optional. but we use two types for text, and bad is that it is implicit, and that is what i do not like.

[asvetlov]

I still like keeping None as valid value for body and text.
Can you live with that?

[fafhrd91]

i'm fine with that. but i think this is wrong

[jettify]

reverted to original PR. response.text is None if response.body is None

[asvetlov]

Thanks, Коля

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.