Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tracing module's type hints #4912

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Fix the tracing module's type hints #4912

merged 3 commits into from
Oct 15, 2020

Commits on Aug 13, 2020

  1. Fix the tracing module's type hints 

    `_SignalArgs` is (was) a supertype of its
arguments and with `Callable ` being _contravariant_
in its arguments, the only way this would've
passed a type check is if the callback were to
(purport to) accept every single one of the
parameter types in a union,
exactly as specified - or `object`.
Either way, the parameter types were not
associated with their corresponding signals
so it would have been possible to append
a callback with a `TraceDnsCacheMissParams`
parameter to an `on_request_start` signal.
    @layday
    layday committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    24848f7 View commit details
    Browse the repository at this point in the history

  2. fixup! Fix the tracing module's type hints

    @layday
    layday committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    d754a6a View commit details
    Browse the repository at this point in the history

  3. fixup! Fix the tracing module's type hints

    @layday
    layday committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    0c68ce3 View commit details
    Browse the repository at this point in the history