[3.7] Import Protocol from typing_extensions (#5111)
#5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditional imports must reference `sys.version_info` directly for type checkers to be able to narrow them. If a type checker cannot tell whether `PY_38` is true, it will combine the imports from both clauses in a `Union`. However, `typing.Protocol` and `typing_extensions.Protocol` are incompatible with each other - they do not inherit from the same class. This produces a type error which is reported to users of aiohttp depending on their type checking configuration.. (cherry picked from commit fb8037a) Co-authored-by: layday <31134424+layday@users.noreply.github.com>
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditional imports must reference
sys.version_infodirectlyfor type checkers to be able to narrow them. If a type checker
cannot tell whether
PY_38is true, it will combine the importsfrom both clauses in a
Union.However,
typing.Protocolandtyping_extensions.Protocolareincompatible with each other - they do not inherit from the same class.
This produces a type error which is reported to users of aiohttp
depending on their type checking configuration..
(cherry picked from commit fb8037a)
Co-authored-by: layday 31134424+layday@users.noreply.github.com