-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test_when_timeout_smaller_second #5117
Fix flaky test_when_timeout_smaller_second #5117
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5117 +/- ##
==========================================
- Coverage 97.50% 97.50% -0.01%
==========================================
Files 43 43
Lines 8824 8822 -2
Branches 1415 1414 -1
==========================================
- Hits 8604 8602 -2
Misses 103 103
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
76d1cb2
to
4fbd279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was sure this problem is fixed already
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
* Fix flaky test_when_timeout_smaller_second * Use absolute tolerance
What do these changes do?
Fix for flaky test_when_timeout_smaller_second
Are there changes in behavior for the user?
No
Related issue number
#5116
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.