Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace headers #5122

Merged
merged 7 commits into from Oct 25, 2020
Merged

Trace headers #5122

merged 7 commits into from Oct 25, 2020

Conversation

derlih
Copy link
Contributor

@derlih derlih commented Oct 24, 2020

What do these changes do?

Add a tracing signal to the client sent headers

Are there changes in behavior for the user?

Yes

Related issue number

#5105

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 24, 2020
@derlih
Copy link
Contributor Author

derlih commented Oct 24, 2020

Currently there is one problem with the generated documentation. I don't see the link to the source code for class TraceRequestHeadersSentParams
Does anyone known how to fix it?

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please apply the last documentation polishing

@asvetlov
Copy link
Member

FYI. We use squash-and-merge strategy for the project.
Thus, you *don't need *to rebase and force-push your changes.
A person who accepts your changes (me for example) is responsible to overview the commit message generated by GitHub and clean it up by removing unnecessary lines from in-progress commits.

Sure, but you still can use rebase and force-push if you want but it doesn't make much sense. The history becomes linear on PR merging, not on the stage of working on the PR.

@asvetlov
Copy link
Member

LGTM, thanks!

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #5122 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5122   +/-   ##
=======================================
  Coverage   97.57%   97.58%           
=======================================
  Files          43       43           
  Lines        8825     8844   +19     
  Branches     1416     1419    +3     
=======================================
+ Hits         8611     8630   +19     
  Misses        100      100           
  Partials      114      114           
Flag Coverage Δ
#unit 97.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.38% <100.00%> (+0.01%) ⬆️
aiohttp/http_writer.py 99.11% <100.00%> (+0.03%) ⬆️
aiohttp/tracing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b63db5...363205a. Read the comment docs.

@asvetlov asvetlov merged commit f244621 into aio-libs:master Oct 25, 2020
asvetlov added a commit that referenced this pull request Oct 25, 2020
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@derlih derlih deleted the trace_headers branch October 25, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants