Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always require typing_extensions library #5123

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Always require typing_extensions library #5123

merged 1 commit into from
Oct 24, 2020

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Oct 24, 2020

Fixes #5107

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 24, 2020
@asvetlov asvetlov changed the base branch from master to 3.7 October 24, 2020 19:16
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #5123 into 3.7 will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.7    #5123      +/-   ##
==========================================
- Coverage   97.52%   97.51%   -0.02%     
==========================================
  Files          44       44              
  Lines        8884     8884              
  Branches     1426     1426              
==========================================
- Hits         8664     8663       -1     
- Misses         99      100       +1     
  Partials      121      121              
Flag Coverage Δ
#unit 97.51% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_fileresponse.py 97.84% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d8677...21719bc. Read the comment docs.

@asvetlov asvetlov merged commit e7dc844 into 3.7 Oct 24, 2020
@asvetlov asvetlov deleted the fix-deps branch October 24, 2020 19:29
GiovanniBussi added a commit to bussilab/py-bussilab that referenced this pull request Nov 4, 2020
@Dreamsorcerer
Copy link
Member

Wouldn't it make more sense to import from typing if it's available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'typing_extensions'
3 participants