Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Switch to external frozenlist and aiosignal libraries (#5293). #5294

Merged
merged 1 commit into from
Nov 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
.vimrc
.vscode
aiohttp/_find_header.c
aiohttp/_frozenlist.c
aiohttp/_frozenlist.html
aiohttp/_headers.html
aiohttp/_headers.pxi
aiohttp/_helpers.c
Expand Down
1 change: 1 addition & 0 deletions CHANGES/5293.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Switch to external frozenlist and aiosignal libraries.
1 change: 0 additions & 1 deletion aiohttp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
DefaultResolver as DefaultResolver,
ThreadedResolver as ThreadedResolver,
)
from .signals import Signal as Signal
from .streams import (
EMPTY_PAYLOAD as EMPTY_PAYLOAD,
DataQueue as DataQueue,
Expand Down
108 changes: 0 additions & 108 deletions aiohttp/_frozenlist.pyx

This file was deleted.

72 changes: 0 additions & 72 deletions aiohttp/frozenlist.py

This file was deleted.

46 changes: 0 additions & 46 deletions aiohttp/frozenlist.pyi

This file was deleted.

34 changes: 0 additions & 34 deletions aiohttp/signals.py

This file was deleted.

12 changes: 0 additions & 12 deletions aiohttp/signals.pyi

This file was deleted.

2 changes: 1 addition & 1 deletion aiohttp/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from typing import TYPE_CHECKING, Any, Callable, Iterator, List, Optional, Type, Union
from unittest import mock

from aiosignal import Signal
from multidict import CIMultiDict, CIMultiDictProxy
from yarl import URL

Expand All @@ -25,7 +26,6 @@
from .client_ws import ClientWebSocketResponse
from .helpers import PY_38, sentinel
from .http import HttpVersion, RawRequestMessage
from .signals import Signal
from .web import (
Application,
AppRunner,
Expand Down
2 changes: 1 addition & 1 deletion aiohttp/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
from typing import TYPE_CHECKING, Awaitable, Optional, Type, TypeVar

import attr
from aiosignal import Signal
from multidict import CIMultiDict
from yarl import URL

from .client_reqrep import ClientResponse
from .signals import Signal

if TYPE_CHECKING: # pragma: no cover
from typing_extensions import Protocol
Expand Down
5 changes: 3 additions & 2 deletions aiohttp/web_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,19 @@
cast,
)

from aiosignal import Signal
from frozenlist import FrozenList

from . import hdrs
from .abc import (
AbstractAccessLogger,
AbstractMatchInfo,
AbstractRouter,
AbstractStreamWriter,
)
from .frozenlist import FrozenList
from .helpers import DEBUG
from .http_parser import RawRequestMessage
from .log import web_logger
from .signals import Signal
from .streams import StreamReader
from .web_log import AccessLogger
from .web_middlewares import _fix_request_current_app
Expand Down
2 changes: 2 additions & 0 deletions requirements/base.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
-r multidict.txt
# required c-ares will not build on windows and has build problems on Macos Python<3.7
aiodns==2.0.0; sys_platform=="linux" or sys_platform=="darwin" and python_version>="3.7"
aiosignal==1.1.2
async-generator==1.10
async-timeout==3.0.1
asynctest==0.13.0; python_version<"3.8"
attrs==20.3.0
brotlipy==0.7.0
cchardet==2.1.7
chardet==3.0.4
frozenlist==1.1.1
gunicorn==20.0.4
idna-ssl==1.1.0; python_version<"3.7"
typing_extensions==3.7.4.3
Expand Down
5 changes: 3 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
],
define_macros=[("HTTP_PARSER_STRICT", 0)],
),
Extension("aiohttp._frozenlist", ["aiohttp/_frozenlist.c"]),
Extension("aiohttp._helpers", ["aiohttp/_helpers.c"]),
Extension("aiohttp._http_writer", ["aiohttp/_http_writer.c"]),
]
Expand Down Expand Up @@ -71,7 +70,9 @@ def build_extension(self, ext):
'asynctest==0.13.0; python_version<"3.8"',
"yarl>=1.0,<2.0",
'idna-ssl>=1.0; python_version<"3.7"',
"typing_extensions>=3.6.5",
"typing_extensions>=3.7.4",
"frozenlist>=1.1.1",
"aiosignal>=1.1.2",
]


Expand Down