-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse boundary from headers while making POST #5575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5575 +/- ##
=======================================
Coverage 93.32% 93.33%
=======================================
Files 102 102
Lines 30140 30160 +20
Branches 2696 2700 +4
=======================================
+ Hits 28129 28149 +20
Misses 1837 1837
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply dccf502 on top of patchback/backports/3.8/dccf502fbcb4bd0f5ab1c7dd5ae1fe69541f4f39/pr-5575 Backporting merged PR #5575 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
What do these changes do?
Now, while making POST request with formdata and explicitly set header
Content-Type
theboundary
will be used from header param if present. Without these changes, HTTP servers will fail to parse formdata because they will be waiting forboundary
fromContent-Type
header, but aiohttp will generate random.Are there changes in behavior for the user?
Only fixes behavior when
boundary
explicitly set. Another cases works as earlier.Related issue number
#5558
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.