Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5534/9c7f3d37 backport][3.8] StaticResource only matches folder-like URL prefix #6179

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 30, 2021

This is a backport of PR #5534 as merged into master (9c7f3d3).

What do these changes do?

I think this fixes #5250.

A static resource like:

routes.static('/foo', '/www/foo')

currently matches /foobar but returns 404. This PR ensures that aforementioned static route does not match /foobar

Are there changes in behavior for the user?

If a user expected /foobar to load the file /www/foo/ar, this PR will violate their expectation.

Related issue number

Fixes #5250

Checklist

I'm not aware of any docs that need to change, but I didn't tick that box because I am not certain.

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
(cherry picked from commit 9c7f3d3)
@asvetlov asvetlov enabled auto-merge (squash) October 30, 2021 15:52
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #6179 (9c7f3d3) into 3.8 (66e281f) will decrease coverage by 4.21%.
The diff coverage is 90.17%.

❗ Current head 9c7f3d3 differs from pull request most recent head c4716cc. Consider uploading reports for the commit c4716cc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.8    #6179      +/-   ##
==========================================
- Coverage   97.52%   93.31%   -4.22%     
==========================================
  Files          44      102      +58     
  Lines        8865    30325   +21460     
  Branches     1429     2724    +1295     
==========================================
+ Hits         8646    28299   +19653     
- Misses        103     1849    +1746     
- Partials      116      177      +61     
Flag Coverage Δ
unit 93.24% <89.96%> (-4.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web_app.py 97.33% <ø> (-1.57%) ⬇️
aiohttp/web_exceptions.py 99.52% <ø> (-0.48%) ⬇️
aiohttp/web_fileresponse.py 97.93% <ø> (-2.07%) ⬇️
aiohttp/web_log.py 100.00% <ø> (ø)
aiohttp/web_middlewares.py 100.00% <ø> (ø)
aiohttp/web_protocol.py 86.41% <ø> (-4.20%) ⬇️
aiohttp/web_request.py 95.91% <ø> (-1.65%) ⬇️
aiohttp/web_response.py 98.41% <ø> (+0.14%) ⬆️
aiohttp/web_routedef.py 98.11% <ø> (+0.01%) ⬆️
aiohttp/web_runner.py 92.34% <ø> (-5.29%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeaea0c...c4716cc. Read the comment docs.

@asvetlov asvetlov merged commit a8f01d7 into 3.8 Oct 30, 2021
@asvetlov asvetlov deleted the patchback/backports/3.8/9c7f3d37fd9ad2aea4d7f382062d52dca9d2bd89/pr-5534 branch October 30, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants