Fix resolving IPv6-only hosts #6204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanaasagi
force-pushed
the
fix-ipv6-resolve
branch
from
4b8b8b7
to
463218b
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
Hanaasagi
changed the title
1 task
asvetlov
requested changes
Nov 2, 2021
asvetlov
reviewed
Nov 14, 2021
| if family == socket.AF_INET6: | ||
| if not (socket.has_ipv6 and address[3]): # type: ignore[misc] | ||
| continue | ||
| if family == socket.AF_INET6 and not socket.has_ipv6: |
There was a problem hiding this comment.
socket.has_ipv6 is a compile-time flag.
A host can disable IPv6 support at system startup time also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix the threaded dns resolver skip the correct dns response when connecting a IPv6-only host.
It will resolve #6195 .
Are there changes in behavior for the user?
No.
Related issue number
#6195
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.