Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6401/5e0e6b70 backport][3.9] Edited the web.run_app declaration. #6405

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 9, 2021

This is a backport of PR #6401 as merged into master (5e0e6b7).

The run_app function takes the "sock" parameter which
can be iterable as well.

What do these changes do?

Edited type annotation of the web.run_app function in according to its behavior.

Are there changes in behavior for the user?

This change will be helpful for people who use a type checker.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

* Edited the web.run_app declaration.

The run_app function takes the "sock" parameter which
can be iterable as well.

* Updated CONTRIBUTORS.txt.

* Added description to CHANGES.

* Use TypingIterable instead of Iterable.

(cherry picked from commit 5e0e6b7)
@patchback patchback bot mentioned this pull request Dec 9, 2021
5 tasks
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) December 9, 2021 21:19
@Dreamsorcerer Dreamsorcerer merged commit 677eec9 into 3.9 Dec 9, 2021
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/5e0e6b7080f2408d5f1dd544c0e1cf88378b7b10/pr-6401 branch December 9, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants